epotyom commented on code in PR #12555: URL: https://github.com/apache/lucene/pull/12555#discussion_r1327853406
########## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java: ########## @@ -1205,7 +1205,15 @@ public SeekStatus seekCeil(BytesRef text) throws IOException { ord = 0; return SeekStatus.END; } else { - seekExact(0L); + // seekBlock doesn't update ord and it repositions bytes when calls getFirstTermFromBlock Review Comment: Good idea, thanks for the suggestion! We still need to handle `block < 0`, but it looks better now and seekBlock leaves term dict in a consistent state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org