gsmiller commented on code in PR #12560:
URL: https://github.com/apache/lucene/pull/12560#discussion_r1327828846
##########
lucene/expressions/src/java/org/apache/lucene/expressions/ExpressionFunctionValues.java:
##########
@@ -39,21 +39,21 @@ class ExpressionFunctionValues extends DoubleValues {
}
@Override
- public boolean advanceExact(int doc) {
+ public boolean advanceExact(int doc) throws IOException {
if (currentDoc == doc) {
return true;
}
+ for (DoubleValues v : functionValues) {
+ v.advanceExact(doc);
Review Comment:
UPDATE: I brought back the lazy `ExpressionFunctionValues#advanceExact`
logic because it created confusion and isn't necessary to remove. It doesn't
hurt to keep this lazy logic in place. I had removed it (making it greedy
again) as an attempt to simplify, but since it created confusion, I figured I'd
bring it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
