mikemccand commented on PR #12337: URL: https://github.com/apache/lucene/pull/12337#issuecomment-1714232934
> But as I think about this feature and how do I see it mature over time, I DO think the payload should be given when ingesting the documents Hmm -- I don't think that's great because we are forcing denormalization onto the user? This is fundamentally nicely normalized content (values per `FacetLabel` not `Document`), so we really should enable indexing it in a denormalized manner. If the user really wants to (inefficiently) denormalize they can use `AssociationFacets` already? > On the other hand, once a facet was added, e.g. "Author/Bob", its value can't change (yet) Actually, I remember someone 😉 adding this nice feature long ago to Lucene to be able to update doc values in-place -- it seems like that could be a great mechanism for updating these denormalized `FacetLabel` values. But we should do that as a followon issue -- let's leave this PR to focus on getting these initial values into the taxo index. We could also (later, separate PR) consider more radical changes to how the taxo index is stored to make it more efficient to update `FacetLabel` values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
