mikemccand commented on PR #12535: URL: https://github.com/apache/lucene/pull/12535#issuecomment-1710320639
OK I made the changes! I also manually tested two failure modes of the clients: taking too long to initially connect, and throwing some sort of exception after testing the lock N times. In both cases the test stderr showed the stderr/out from the clients, hopefully making it easier to test in the future. I did notice one odd thing: on test failure, I seemed to have a leftover `test.lock` in the root directory of the checkout, which is very odd. The test creates a new temp directory and is supposed to use that directory to create its test lock ... so I'm not yet sure how that happened. Or maybe I am just hallucinating ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
