mikemccand commented on issue #12536: URL: https://github.com/apache/lucene/issues/12536#issuecomment-1706251517
Sorry, what went wrong when you tried to remove `lastPosBlockOffset`? Skipping is (currently) only at every 8 blocks boundaries right? So doesn't the skip data already know how many positions were skipped when it skips into a spot? Hmm I think I see -- there are in general more positions blocks (since there can of course be many more positions than doc/freq) than doc/freq blocks, and so as `PostingsEnum` is skipping or reading positions, it must know when it transitions into the final (`vInt` encoded) chunk of positions? Hmm but again it seems like tracking number of positions skipped/read vs `totalTermFreq` should be enough? Maybe make a PR adding a nice comment explaining why we really do need this `int lastPosBlockOffset`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
