javanna commented on code in PR #12516:
URL: https://github.com/apache/lucene/pull/12516#discussion_r1315608401
##########
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##########
@@ -95,20 +95,17 @@ public Query rewrite(IndexSearcher indexSearcher) throws
IOException {
}
private TopDocs[] sequentialSearch(
- List<LeafReaderContext> leafReaderContexts, Weight filterWeight) {
- try {
- TopDocs[] perLeafResults = new TopDocs[leafReaderContexts.size()];
- for (LeafReaderContext ctx : leafReaderContexts) {
- perLeafResults[ctx.ord] = searchLeaf(ctx, filterWeight);
- }
- return perLeafResults;
- } catch (Exception e) {
- throw new RuntimeException(e);
Review Comment:
This looks like a way to compensate for the exception wrapping when doing
concurrent search, by wrapping when doing sequential search do. This made it
easier to test knn vector queries so far, regardless of whether rewrite is done
concurrently or not. If we fix the root cause and remove the wrapping, we no
longer need to artificially wrap here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
