cpoerschke commented on issue #12538: URL: https://github.com/apache/lucene/issues/12538#issuecomment-1705518873
My interpretation of this is that for queries not matching on terms (i.e. those that call `visitLeaf`) then an `acceptField` call is not applicable since there are no _"terms from this field"_ to accept or not accept. However as illustrated by the exploratory link-to-follow pull request there are several `visitor.acceptField` guards for `visitor.visitLeaf` calls. Would appreciate any insights on this e.g. can the guards be removed and/or can we clarify the `QueryVisitor` javadocs somehow to make it clearer when to (not) call `acceptFields` first? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
