mikemccand commented on PR #12530: URL: https://github.com/apache/lucene/pull/12530#issuecomment-1701119507
Thanks @rmuir > as far as the exorcise stuff, I think a good next step would be to start writing some unit tests that invoke exorcise? we have a grand total of zero tests exercising-exorcise, and I think it is part of the problem. Yeah +1! It's terrifying to have zero test coverage for such a dangerous feature! > yeah looks good. I think we should validate all the commit points ... and in the future also recurse in such a way that we validate all the segments they may include too. I like the recursion idea. We just need to recurse on those segments not ALSO referenced by the newer/newest commit point. And I guess somehow fix the `Status` to reflect which commit point(s) are affected by any detected corrupted segments. It would also be nice to be able to fix the missing `_N.si` case, but it's not clear to me how ... but yeah, we need test coverage first, before we try to "improve" the exorcism case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
