stefanvodita commented on code in PR #12337: URL: https://github.com/apache/lucene/pull/12337#discussion_r1298912817
########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyIndexReader.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.taxonomy.directory; + +import java.io.IOException; +import org.apache.lucene.index.DirectoryReader; +import org.apache.lucene.store.Directory; + +/** + * This is like a {@link DirectoryTaxonomyReader}, except it provides access to the underlying + * {@link DirectoryReader} and full path field name. + */ +public class DirectoryTaxonomyIndexReader extends DirectoryTaxonomyReader { Review Comment: Great point @epotyom! I’ve thought a bit more about this and I’d like to consider exposing the `IndexReader` of `DirectoryTaxonomyReader` by making `getInternalIndexReader` public instead of protected. I actually like this solution better than what I coded up previously. It’s cleaner, it’s backwards compatible, and a user could have already gotten the `IndexReader` anyway by extending `DirectoryTaxonomyReader`. I’m curious if anyone has other ideas though. ########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyIndexReader.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.taxonomy.directory; + +import java.io.IOException; +import org.apache.lucene.index.DirectoryReader; +import org.apache.lucene.store.Directory; + +/** + * This is like a {@link DirectoryTaxonomyReader}, except it provides access to the underlying + * {@link DirectoryReader} and full path field name. + */ +public class DirectoryTaxonomyIndexReader extends DirectoryTaxonomyReader { Review Comment: Great point @epotyom! I’ve thought a bit more about this and I’d like to consider exposing the `IndexReader` of `DirectoryTaxonomyReader` by making `getInternalIndexReader` public instead of protected. I actually like this solution better than what I coded up previously. It’s cleaner, it’s backwards compatible, and a user could have already gotten the `IndexReader` anyway by extending `DirectoryTaxonomyReader`. I’m curious if anyone has other ideas though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
