jimczi commented on code in PR #12510: URL: https://github.com/apache/lucene/pull/12510#discussion_r1295387479
########## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinFloatKnnVectorQuery.java: ########## @@ -38,6 +38,7 @@ /** * kNN float vector query that joins matching children vector documents with their parent doc id. + * The top documents returned are the child document ids and the calculated scores. */ Review Comment: Same here? ########## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinByteKnnVectorQuery.java: ########## @@ -36,7 +36,10 @@ import org.apache.lucene.util.BitSet; import org.apache.lucene.util.Bits; -/** kNN byte vector query that joins matching children vector documents with their parent doc id. */ +/** + * kNN byte vector query that joins matching children vector documents with their parent doc id. The + * top documents returned are the child document ids and the calculated scores. Review Comment: Maybe add an example on how to mix with root document queries? Something like: ``` ToParentBlockJoinByteKnnVectorQuery childQuery = ... Query query = new ToParentBlockJoinQuery(childQuery, parentsFilter, ..) ... ``` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
