benwtrent opened a new pull request, #12510:
URL: https://github.com/apache/lucene/pull/12510

   While integrating, I discovered a frustrating bug :(
   
   The current query is returning parent-id's based off of the nearest child-id 
score. However, its difficult to invert that relationship (meaning determining 
what exactly the nearest child was during search).
   
   So, I changed the new `ToParentBlockJoin[Byte|Float]KnnVectorQuery` to 
return the nearest child-id instead of just that child's parent id. The results 
are still diversified by parent-id.
   
   Now its easy to determine the nearest child vector as that is what the query 
is returning. To determine its parent, its as simple as using the previously 
provided parent bit set. 
   
   I realize that this might make the name weird. I am happy to consider a new 
name. All the "join" names are confusing to me already.
   
   I am happy to change the name. 
   
   Since this is iterating on an unreleased query and related to: 
https://github.com/apache/lucene/pull/12434 I am not adding a change log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to