sabi0 opened a new issue, #12501:
URL: https://github.com/apache/lucene/issues/12501

   ### Description
   
   `Lucene70Codec` had:
   ```
   private final PostingsFormat defaultFormat = 
PostingsFormat.forName("Lucene50");
   ```
   
   In the `Lucene80Codec` PostingsFormat instantiation was moved to the 
constructor. Presumably to pass the additional `fstLoadMode` parameter?
   
https://github.com/apache/lucene/commit/28e8a30b536a39e5539ac6e8b9407d31724c8857#diff-3a74c1b72ab52e54dfcdc9de142b4331b372c11bcca87842b001c30f89ce58ebR98
   
   In a subsequent commit the code was reverted to the default PostingsFormat 
constructor:
   
https://github.com/apache/lucene/commit/651f41e21bd3df98f70d2673295db29506e3d2e6#diff-3a74c1b72ab52e54dfcdc9de142b4331b372c11bcca87842b001c30f89ce58ebR96
   
   But the SPI call `PostingsFormat.forName()` was not restored. And is still 
missing in `Lucene95Codec`:
   
https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95Codec.java#L121
   
   Restore the SPI extension point to allow overriding the PostingsFormat 
without having to override the Codec?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to