zhaih commented on PR #12480: URL: https://github.com/apache/lucene/pull/12480#issuecomment-1668600408
Thank you @Jackyrie2 for a lot of benchmarking! Since we have already made it lightweight enough (requires no extra memory usage on NeighborArray) and the benchmark has shown mostly positive results(Benchmark does have quite a lot of noises, especially if you're running it with your local machine, if you want , maybe write some simple bash loop and run the evaluation 3 - 5 times and use the average), I would say this PR is a good optimization. But it does need some more documentation I think as the NeighborArray is already complex enough, so I will try to carefully review it again recently. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
