benwtrent commented on issue #12342: URL: https://github.com/apache/lucene/issues/12342#issuecomment-1667803435
@searchivarius && @msokolov do we think any additional testing should be done? Or are we comfortable with https://github.com/apache/lucene/pull/12479 going through as is with the testing done? FYI, I reran my tests locally. I re-read the requirements and it seemed that in the "transformed" case, we SHOULD be using `euclidean` as the similarity comparator. My tests used "dot-product" (angular). So, non-transformed == max-inner product and trainsformed == euclidean. In my local reruns, there is almost no difference. The random case looks very similar, the ordered & reverse cases are more equal between the two runs, but the pareto graphs are effectively the same :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
