jpountz commented on PR #12488:
URL: https://github.com/apache/lucene/pull/12488#issuecomment-1666957807
I realized I made a mistake in the benchmark, my baseline was a couple
changes behind and probably missed #12475. I reran the benchmark correctly, and
there is actually a small slowdown:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
CountOrHighHigh 50.49 (11.0%) 48.07
(12.0%) -4.8% ( -25% - 20%) 0.188
CountOrHighMed 79.22 (10.3%) 75.80
(11.4%) -4.3% ( -23% - 19%) 0.210
CountAndHighMed 195.82 (3.4%) 194.63
(4.3%) -0.6% ( -8% - 7%) 0.622
CountAndHighHigh 51.30 (3.8%) 51.16
(4.9%) -0.3% ( -8% - 8%) 0.851
CountPhrase 12.54 (2.5%) 12.54
(3.6%) -0.0% ( -6% - 6%) 0.996
CountTerm 9052.13 (3.3%) 9086.40
(3.3%) 0.4% ( -6% - 7%) 0.719
PKLookup 241.61 (3.3%) 243.34
(2.6%) 0.7% ( -5% - 6%) 0.449
```
I will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
