mikemccand commented on code in PR #12472: URL: https://github.com/apache/lucene/pull/12472#discussion_r1280593391
########## lucene/core/src/test/org/apache/lucene/util/automaton/TestStringsToAutomaton.java: ########## @@ -142,22 +141,11 @@ private void checkAutomaton(List<BytesRef> expected, Automaton a, boolean isBina } // Make sure every term produced by the automaton is expected - FiniteStringsIterator it = new FiniteStringsIterator(a); Review Comment: Hmm why did you remove the `isBinary` case for this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org