gsmiller commented on PR #12454: URL: https://github.com/apache/lucene/pull/12454#issuecomment-1656481929
> Overall, I like the previous code a bit better, it's cleaner and more concise, although cachedOrdMaps looks confusing at first. Maybe it just needs a comment explaining why using a map is convenient (we can synchronize on it, we can call Accountables.namedAccountables with it)? I'd like to hear what others think. Personally, I agree with this. Maybe we clean up the documentation and leave as-is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
