gf2121 commented on PR #12465: URL: https://github.com/apache/lucene/pull/12465#issuecomment-1655202239
> For example, what if we assigned disi.exists to false here? Sorry but I do not think we should do this change indeed : 1. If a field exists in doc 1, 3. Calling `advanceExact(1)` after calling `advanceExact(2)` will return **false**. This is incorrect. 2. An assert error should help caller side find out bugs that calling API in an unexpected way, which is better than handle it silently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
