jpountz commented on code in PR #12415: URL: https://github.com/apache/lucene/pull/12415#discussion_r1276558624
########## lucene/core/src/java/org/apache/lucene/search/BooleanScorer.java: ########## @@ -119,6 +121,7 @@ public BulkScorerAndDoc get(int i) { final Score score = new Score(); final int minShouldMatch; final long cost; + final boolean needsScores; final class OrCollector implements LeafCollector { Review Comment: Indeed, we never use it for conjunctions. It's probably faster than BS2 for conjunctions at times, it would be interesting to find a good heuristic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org