uschindler commented on code in PR #12436:
URL: https://github.com/apache/lucene/pull/12436#discussion_r1276136883
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsFormat.java:
##########
@@ -185,6 +188,11 @@ public KnnVectorsReader fieldsReader(SegmentReadState
state) throws IOException
return new Lucene95HnswVectorsReader(state);
}
+ @Override
+ public int getMaxDimensions(String fieldName) {
+ return MAX_DIMENSIONS;
+ }
Review Comment:
It is public. I think it's good to have the constant for this codec so for
consistency it must return its own constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
