jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1272560387
########## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ########## @@ -311,7 +369,6 @@ void searchLevel( graphSeek(graph, level, topCandidateNode); int friendOrd; while ((friendOrd = graphNextNeighbor(graph)) != NO_MORE_DOCS) { - assert friendOrd < size : "friendOrd=" + friendOrd + "; size=" + size; Review Comment: Fair enough, but is this really worth duplicating a 500 line Searcher class for, especially since there are other tests now that would break if this were a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org