ChrisHegarty commented on code in PR #12410:
URL: https://github.com/apache/lucene/pull/12410#discussion_r1250432743
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -15,79 +15,97 @@
* limitations under the License.
*/
-package org.apache.lucene.util;
+package org.apache.lucene.internal.vectorization;
import java.lang.Runtime.Version;
+import java.lang.StackWalker.StackFrame;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.Locale;
import java.util.Objects;
import java.util.logging.Logger;
+import java.util.stream.Stream;
+import org.apache.lucene.util.SuppressForbidden;
+import org.apache.lucene.util.VectorUtil;
+
+/**
+ * A provider of vectorization implementations. Depending on the Java version
and availability of
+ * vectorization modules in the Java runtime this class provides optimized
implementations (using
+ * SIMD) of several algorithms used throughout Apache Lucene.
+ *
+ * @lucene.internal
+ */
+public abstract class VectorizationProvider {
Review Comment:
I'm ok with "vectorization".
Yet another alternative ;-) Another thought I had was to actually leave the
default scalar implementation where it was. Then the provider would be a
provider of vectorized implementations, Something like,
`VectorizedProvider::getInstanceOrNull`. That way the new package consists of
just Panama code and the light-weight interfaces (no scalar code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
