uschindler commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1246177620
########## lucene/core/src/java/org/apache/lucene/index/DocsWithVectorsSet.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.index; + +import org.apache.lucene.util.FixedBitSet; +import org.apache.lucene.util.RamUsageEstimator; + +import java.util.Stack; Review Comment: Please don't use the outdated `Stack` class, which is also synchronized. Modern replacement is `ArrayDeque` implementing `Deque` interface. ########## lucene/core/src/java/org/apache/lucene/index/FloatVectorValues.java: ########## @@ -57,4 +63,13 @@ public final long cost() { * @return the vector value */ public abstract float[] vectorValue() throws IOException; + + /** + * Return the document ID corresponding to the input vector id(ordinal) + * @param ord vector ID(ordinal) + * @return the document ID + */ + public int ordToDoc(int ord){ Review Comment: The problem with the new implementation is that ordinal numbers need to get longs (like in SortedSetDocValues), because as each document of a 2B docs index sement may have more than one value, so the total number of ordinals may go beyond 2B. Of course this needs more work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
