uschindler commented on issue #12396: URL: https://github.com/apache/lucene/issues/12396#issuecomment-1611811043
Hi, if you look at the first line of `ForUtil.java`, you will see the following comment: ```java // This file has been automatically generated, DO NOT EDIT ``` Actually the class is generated by a Python Script and placed in several folders (also for backwards codecs): https://github.com/apache/lucene/blob/main/gradle/generation/forUtil.gradle So there should be similar way to regenerate the variants. Of course this is a bit hard to implement with the current multi-release JAR setup, so there's a bit more work needed. I am happy to help, but give me a few days to think about it. I don't want to rush anything. Also Backwards-codecs JAR file has no support for Multi-Release and the whole panama lookup won't work there, but I would suggest: - For the backwards compatibility codec we keep the code as is. - Or move ForUtil to Lucene core's util package and make it public. Both impls are same, just in different packages, so I tend to move them to Lucene Core and include in VectorUtil. I have some ideas, but we can hide it from public code using the provider interfaces we already have to lookup the instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
