jpountz commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1245197338
########## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingLeafCollector.java: ########## @@ -57,4 +58,11 @@ public void collect(int doc) throws IOException { public DocIdSetIterator competitiveIterator() throws IOException { return in.competitiveIterator(); } + + @Override + public void finish() throws IOException { + assert finishCalled == false; Review Comment: Yes, it's disallowed by design since `LeafCollector#collect` must collect doc IDs in doc ID order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org