sohami commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1594871500
@javanna I am also thinking with regards to too many constructor can we see if deprecating the ones with IndexReader as inputs and keeping the ones with IndexReaderContext over the time will make sense. For the new one as well we can avoid adding one with IndexReader if we go down that path vs non final variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
