benwtrent commented on code in PR #12372:
URL: https://github.com/apache/lucene/pull/12372#discussion_r1232396894
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -262,7 +274,6 @@ private NeighborQueue searchLevel(
int visitedLimit)
throws IOException {
int size = graph.size();
- NeighborQueue results = new NeighborQueue(topK, false);
Review Comment:
A minor thing, could we `assert results.isMinHeap()` or something? Of course
`isMinHeap()` would be a package private method.
Just to catch bad usage within tests if somebody accidentally uses a max
heap here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
