javanna commented on code in PR #12369:
URL: https://github.com/apache/lucene/pull/12369#discussion_r1229359014
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##########
@@ -1965,9 +1966,9 @@ public static IndexSearcher newSearcher(
.addClosedListener(cacheKey ->
TestUtil.shutdownExecutorService(ex));
}
IndexSearcher ret;
+ int maxDocPerSlice = random.nextBoolean() ? 1 : 1 + random.nextInt(1000);
+ int maxSegmentsPerSlice = random.nextBoolean() ? 1 : 1 +
random.nextInt(10);
Review Comment:
I do think that when `useThreads` is true, we should do our best to leverage
concurrency at least half of the runs, rather than 0.2% of the runs. Being this
dependent on the number of docs and segments makes it particularly challenging
to come up with a good default value. Possibly the proposed behaviour is good
for tests that index a low amount of docs, which is the majority of the lucene
tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
