mikemccand commented on code in PR #12345:
URL: https://github.com/apache/lucene/pull/12345#discussion_r1224498275
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException {
for (Query rewrittenQuery = query.rewrite(this);
rewrittenQuery != query;
rewrittenQuery = query.rewrite(this)) {
+ if (queryTimeout != null) {
Review Comment:
This is an improvement, however, it's only checking at the very end of
rewrite? Which is not so different from checking at the start of iterating
through the hits? I.e. in practice it seems like it won't make much of an
improvement?
I wonder if we can somehow check the timeout during rewrite? Seems tricky
though ...
The timeout implementation that wraps `Directory` can achieve that by
checking during I/O.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
