sohami commented on code in PR #12348: URL: https://github.com/apache/lucene/pull/12348#discussion_r1223581829
########## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ########## @@ -882,27 +885,6 @@ public IndexReaderContext getTopReaderContext() { return readerContext; } - /** - * A class holding a subset of the {@link IndexSearcher}s leaf contexts to be executed within a - * single thread. - * - * @lucene.experimental - */ - public static class LeafSlice { - - /** - * The leaves that make up this slice. - * - * @lucene.experimental - */ - public final LeafReaderContext[] leaves; - - public LeafSlice(List<LeafReaderContext> leavesList) { - Collections.sort(leavesList, Comparator.comparingInt(l -> l.docBase)); - this.leaves = leavesList.toArray(new LeafReaderContext[0]); - } - } Review Comment: Ack I can move it back since it was getting used by `IndexSearcher` and `SliceExecutor`, I thought of moving it out. But you are right it can break the consumers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org