craigtaverner commented on code in PR #12353:
URL: https://github.com/apache/lucene/pull/12353#discussion_r1223240259
##########
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##########
@@ -1090,17 +1090,22 @@ private static final Node splitPolygon(final Node a,
final Node b, boolean edgeF
* Determines whether a diagonal between two polygon nodes lies within a
polygon interior. (This
* determines the validity of the ray.) *
*/
- private static final boolean isValidDiagonal(final Node a, final Node b) {
+ private static boolean isValidDiagonal(final Node a, final Node b) {
+ if (a.next.idx == b.idx
+ || a.previous.idx == b.idx
+ // check next edges are locally visible
+ || isLocallyInside(a.previous, b) == false
Review Comment:
I thought the `== false` pattern was an elasticsearch pattern, not a lucene
pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
