uschindler commented on PR #12357: URL: https://github.com/apache/lucene/pull/12357#issuecomment-1582821999
Wouldn't aligning the refill against the buffer size be better in general? My idea would be to always round down to multiples of buffer size. This would also cause the undelying hardware to read aligned blocks (unless it is a CFS file) and not do multiple reads per buffer size. I know this might affect other cases positively or negatively, but to me this looks like more what MMapDirectory is doing behind the OS layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
