zhaih commented on code in PR #12325: URL: https://github.com/apache/lucene/pull/12325#discussion_r1205152707
########## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ########## @@ -81,11 +81,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException { filterWeight = null; } - Executor executor = indexSearcher.getExecutor(); + SliceExecutor sliceExecutor = indexSearcher.getSliceExecutor(); TopDocs[] perLeafResults = Review Comment: Usually when I see an array with name `perLeafxxx` I would assume they're ordered by leaf order, altho this doesn't matter right now, but just in case in the future some one want to do something based on leaf order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org