uschindler commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1561414222
Should we now start to prepare this for inclusion in main and 9.x? With Java 21 MMAP I could then also start to extract apijars (it needs a newer asm version, but thats done already). We should mybe think again first about the API design: - for now we should keep the internals private (thats done here, the javadocs do not offer any new public classes; VectorUtil looks as before) - Are we open to extends this away from VectorUtil? Of course this only works for code that can be implemented isolated from the Lucene implementations (an isolated implementation of an algorithm). But would it be possible to also call from postings into this code, like packed readers instances or similar. If we can't do this, is it possible to have a common interface and let VectorUtilProvider return an instance (the conventional one vs. Panama one) of PackedReader implementations? In that case we should move the vectorizable classes and hide them from users and add factories in VectorUtil (like VectorUtil#getPackedXYReader) to allow to request an implementation of an algorithms. At moment I see no chance to vectorize stuff that relies on the common Lucene iterator pattern. But all stuff that works block based could be moved. If we are fine with the current approach, we could merge this to main 9.x and then proceed to move more stuff into VectorUtil. As all APIs are hidden at moment, there's no risk in merging this. We can decide to change the VectorUtilProvider and rename/refactor it, as it is private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
