rmuir commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1559929746
> Sorry for again changing. I was not happy with the bitsize code in the lookup function. I used a very simple approach: The constructor of the provider throws UnsupportedOperationException with a message. The provider lookup catches this exception and falls back to default provider. This looks cleanest to me. Thanks! Do you think we should nuke related 128-bit checks in the binary methods of the file? Or replace them with asserts? Example: https://github.com/apache/lucene/blob/f9711e9a30f3e4be6cf237091b6642b222178325/lucene/core/src/java20/org/apache/lucene/util/VectorUtilPanamaProvider.java#L273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
