rmuir commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1557660515
i think another approach would be to generalize the 256 algorithm (no splitting into parts) to also work with 512? No need to have a separate `if` for 512 when its the same algo i think? but right now, i can't see us avoiding two algorithms: one with splitting (128-bit vectors, since there isnt a ByteVectors.SPECIES_32), and another one without splitting (256/512-bit vecotrs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
