hydrogen666 commented on PR #11998: URL: https://github.com/apache/lucene/pull/11998#issuecomment-1557118792
> In previous version, `StoredFieldsReader` is cached in `ThreadLocal`, but now we need to `clone` `StoredFieldsReader` every time if we need to visit store fields. Will this PR cause any performance issue? It is reasonable to clone `StoredFieldsReader` in one `IndexSearcher` context because one search request may hit many docs, but in some circumstances such as get by `_id` in Elasticsearch, cloning `StoredFieldsReader` every time may cause performance issue? Does my aforementioned concern make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
