rmuir commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1556405150
and here's the results on my aarch64 mac, which has only 128-bit vectors and gets that disappointing generic impl: ``` Benchmark (size) Mode Cnt Score Error Units BinaryDotProductBenchmark.dotProductNew 1 thrpt 5 334.839 ± 0.368 ops/us BinaryDotProductBenchmark.dotProductNew 128 thrpt 5 34.097 ± 0.026 ops/us BinaryDotProductBenchmark.dotProductNew 207 thrpt 5 22.045 ± 0.063 ops/us BinaryDotProductBenchmark.dotProductNew 256 thrpt 5 18.782 ± 0.603 ops/us BinaryDotProductBenchmark.dotProductNew 300 thrpt 5 15.932 ± 0.049 ops/us BinaryDotProductBenchmark.dotProductNew 512 thrpt 5 9.985 ± 0.010 ops/us BinaryDotProductBenchmark.dotProductNew 702 thrpt 5 7.322 ± 0.001 ops/us BinaryDotProductBenchmark.dotProductNew 1024 thrpt 5 5.146 ± 0.002 ops/us BinaryDotProductBenchmark.dotProductOld 1 thrpt 5 343.722 ± 0.640 ops/us BinaryDotProductBenchmark.dotProductOld 128 thrpt 5 24.981 ± 0.102 ops/us BinaryDotProductBenchmark.dotProductOld 207 thrpt 5 14.944 ± 0.128 ops/us BinaryDotProductBenchmark.dotProductOld 256 thrpt 5 12.541 ± 0.006 ops/us BinaryDotProductBenchmark.dotProductOld 300 thrpt 5 10.663 ± 0.005 ops/us BinaryDotProductBenchmark.dotProductOld 512 thrpt 5 6.198 ± 0.019 ops/us BinaryDotProductBenchmark.dotProductOld 702 thrpt 5 4.531 ± 0.062 ops/us BinaryDotProductBenchmark.dotProductOld 1024 thrpt 5 3.108 ± 0.003 ops/us ``` I'd be curious how we could implement this with better performance, especially if we can just have a single generic impl like the float one. I feel like I must be doing it wrong :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
