dweiss commented on code in PR #12316:
URL: https://github.com/apache/lucene/pull/12316#discussion_r1199252099
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java:
##########
@@ -155,7 +155,7 @@ public class Dictionary {
boolean checkCompoundCase, checkCompoundDup, checkCompoundRep;
boolean checkCompoundTriple, simplifiedTriple;
int compoundMin = 3, compoundMax = Integer.MAX_VALUE;
- List<CompoundRule> compoundRules; // nullable
+ CompoundRule[] compoundRules; // nullable
Review Comment:
LGTM.
Would it be any different if you passed the size to ArrayList's constructor?
I'm guessing streams have an associated cost but if it's nearly the same then
I'd go with less verbose version (collections).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
