uschindler commented on code in PR #12311: URL: https://github.com/apache/lucene/pull/12311#discussion_r1199048935
########## lucene/core/src/java/org/apache/lucene/internal/vector/DefaultVectorUtilProvider.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.internal.vector; + +/** + * The default VectorUtil provider implementation. + * + * @lucene.internal + */ +public final class DefaultVectorUtilProvider implements VectorUtilProvider { Review Comment: IMHO, this one should be package private like the Java 20 one. In general I am not really happy with the additional package? I know you are a fan of the module system, but most users still don't use it and our Javadocs also show all packages (including internal ones). Is it really needed to have the vector stuff in a separate package. For MMAPDirectory I made sure to hide everything, including the provider as it is no public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
