uschindler commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1198085290
##########
gradle/generation/panama-foreign.gradle:
##########
@@ -45,13 +45,14 @@ configure(project(":lucene:core")) {
javaLauncher.get()
return true
} catch (Exception e) {
- logger.warn('Launcher for Java {} is not available; skipping
regeneration of Panama Foreign API JAR.', jdkVersion)
+ logger.warn('Launcher for Java {} is not available; skipping
regeneration of Panama Foreign & Vector API JAR.', jdkVersion)
logger.warn('Error: {}', e.cause?.message)
logger.warn("Please make sure to point env 'JAVA{}_HOME' to exactly
JDK version {} or enable Gradle toolchain auto-download.", jdkVersion,
jdkVersion)
return false
}
}
-
+
+ jvmArgs = ["--add-modules=jdk.incubator.vector"]
Review Comment:
This should not be needed, as the extractor reads the jrt filesystem
directly!? It should run without this flag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
