rmuir commented on PR #12286: URL: https://github.com/apache/lucene/pull/12286#issuecomment-1545027201
i really like it, thanks for doing this! code is still simple, but more robust (heap instead of stack!) and the cycle detection is a really nice bonus. thanks for the unit test for that. i made a cosmetic suggestion. Also, should we add a basic test that the toposort works correctly to TestOperations? TestAutomaton does exercise it too, but I'm not sure how well or how easy to debug if it fails :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
