romseygeek commented on code in PR #12285:
URL: https://github.com/apache/lucene/pull/12285#discussion_r1190841595
##########
lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java:
##########
@@ -28,54 +29,30 @@
class SliceExecutor {
private final Executor executor;
- public SliceExecutor(Executor executor) {
- this.executor = executor;
+ SliceExecutor(Executor executor) {
+ this.executor = Objects.requireNonNull(executor, "Executor is null");
}
- public void invokeAll(Collection<? extends Runnable> tasks) {
-
- if (tasks == null) {
Review Comment:
Do we not need this null check for `tasks` any more? Maybe replace it with
an assertion given this is all package private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
