msokolov commented on PR #12254: URL: https://github.com/apache/lucene/pull/12254#issuecomment-1538416109
uh-oh this PR metastasized a bit iin the past few days. I think it was a better plan to commit the graph builder util class on its own prior to cutting over the codec usage. Can we separate these into two stages? I expect a lot of discussion around the codec usage/index writer integration and I don't want it to block getting the algorithmic change in. On the other hand, since you have done the integration, are you able to test it using `KnnGraphTester` (recently moved to `luceneutil` package)? Or with some other tool that tests the whole integration, like `ann-benchmarks`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
