MarcusSorealheis commented on code in PR #12245:
URL: https://github.com/apache/lucene/pull/12245#discussion_r1186249484
##########
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoin.java:
##########
@@ -889,7 +889,8 @@ public void testRandom() throws Exception {
Explanation explanation = joinS.explain(childJoinQuery, hit.doc);
Document document = joinS.storedFields().document(hit.doc - 1);
int childId = Integer.parseInt(document.get("childID"));
- assertEquals(hit.score, explanation.getValue().floatValue(), 0.1f);
+ assertTrue(explanation.isMatch());
+ assertEquals(hit.score, explanation.getValue().doubleValue(), 0.0f);
Review Comment:
Looks great. Thanks for cleanup!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
