uschindler commented on PR #12197: URL: https://github.com/apache/lucene/pull/12197#issuecomment-1536288455
We should maybe have a test if a subclass of query does not override any of both methods. In this case calling `rewrite()` should return `this` in both cases. I assume this is already checked indirectly by other tests, but maybe make an explicit test: Just subclass query not overriding anything and then call both rewrite methods and check that both return itsself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
