MarcusSorealheis commented on issue #12204: URL: https://github.com/apache/lucene/issues/12204#issuecomment-1529326767
@mkhludnev or @kashkambath I'm almost done with the PR but there are a few problems: 1. The tests failed in floating ways initially because in some places score is a double, and others it is a float. Is there a place where the choice between the two is documented or a reason for the difference? I don't think I'm the one to come and start changing things without a good reason or reviewing the documentation/prior references. 2. The tests were made to work but not truly. Always returning best score was not a functional use of score mode, as it basically ignored it. For example, I think we need to be clear on the behavior of `ToParentBlockJoinQuery`. For example, should we return a `Exaplanation.match()` if a parent matches a query, but no child of the parent doc matches the query? IN the case, would the number of matches be zero, despite the fact that we returned a document. Some details about this query seem and aligning on the behavior/requirements would be helpful before I go further. After digging in a couple times over the past week, I have some rough idea about how we could make things work, but I am curious about how they should work. I don't have strong opinions other than the fact that this work is important. Explain is very useful for debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
