MarcusSorealheis opened a new pull request, #12245:
URL: https://github.com/apache/lucene/pull/12245

   ### Description
   
   Today, `explain()` returns the max score regardless of the value of 
`toParentBlockJoin` as documented in 
[#12204](https://github.com/apache/lucene/issues/12204). This is a simple PoC 
to address the issue. 
   
   Please note: I still need to write three more tests. I'm toying around with 
a few approaches and trying to be mindful of opportunity costs and readability 
given the size of the project. I am curious if anyone has any thoughts around 
parameterized tests vs individual methods for each score mode other than 
`None`, which was already tested. 
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to