alessandrobenedetti commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1520575561
Hi @jimczi , @msokolov , I don't think it was @dantuzi intention to ignore you, I think he just misread your comment as a suggestion of improvement rather than a blocker. I had Daniele and Ilaria extensively testing and benchmarking the contribution in the last few months, we left the PR open for various months and we thought it was in a good state to merge (being a new feature, not impacting existing works). I really appreciate you spending the time to find this problem and we'll take a look in detail in 2 days (Wednesday 26th). Given that, and not entering the technical merit until the 26th (I don't have the time right now to process your insights), is it worth reverting or we can simply fix it/commit a workaround as soon as we find it in the next few days? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
