RS146BIJAY commented on issue #12228: URL: https://github.com/apache/lucene/issues/12228#issuecomment-1501907350
I agree exceptions like `VirtualMachineError` should be considered as tragic and we should avoid deleting files in those case. Actually my major concern was why segment merge failure due to disk full is considered tragedy (updated description)? I believe IOException thrown due to disk full should not be considered as tragedy as it will cause unreferenced file (some files are huge) to continue to occupy space on the node though it is not available for query/update. Disk Full does not necessarily means there is an issue on the system/disk and operation like deleting files should be allowed. If wasting IO/CPU cycles is the only concern as mentioned in [this issue](https://issues.apache.org/jira/browse/LUCENE-6579), why not modify the merge policy itself to not allow segment merge in case enough space is not available. Let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
